Closed alesnovak-s1 closed 6 months ago
20 files ± 0 20 suites ±0 31m 48s :stopwatch: -13s 1 486 tests + 9 1 466 :heavy_check_mark: + 9 20 :zzz: ±0 0 :x: ±0 7 101 runs +41 6 876 :heavy_check_mark: +41 225 :zzz: ±0 0 :x: ±0
Results for commit e3a43173. ± Comparison against base commit ae9f3d64.
:recycle: This comment has been updated with latest results.
Attention: Patch coverage is 91.60156%
with 43 lines
in your changes are missing coverage. Please review.
Project coverage is 81.68%. Comparing base (
ae9f3d6
) to head (e3a4317
).
Great work, especially with end to end tests.
I assume we plan add to some additional high level documentation (in addition to the "lower level" monitor documentation) here at some point as part of a separate repo - https://app.scalyr.com/help/scalyr-agent-k8s, right?
EDIT: Never mind, I see we already have a ticket for that.
Support for multiple account per container. Doc - https://github.com/scalyr/scalyr-agent-2/blob/DTIN-3339_many_workers_per_log_file/docs/monitors/kubernetes_monitor.md#configuring-multiple-accounts-per-container
https://sentinelone.atlassian.net/browse/DTIN-3339