scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 60 forks source link

Support sending events to multiple Dataset accounts via K8s annotations #1238

Closed alesnovak-s1 closed 6 months ago

alesnovak-s1 commented 7 months ago

Support for multiple account per container. Doc - https://github.com/scalyr/scalyr-agent-2/blob/DTIN-3339_many_workers_per_log_file/docs/monitors/kubernetes_monitor.md#configuring-multiple-accounts-per-container

https://sentinelone.atlassian.net/browse/DTIN-3339

github-actions[bot] commented 7 months ago

Test Results

     20 files  ±  0       20 suites  ±0   31m 48s :stopwatch: -13s 1 486 tests +  9  1 466 :heavy_check_mark: +  9    20 :zzz: ±0  0 :x: ±0  7 101 runs  +41  6 876 :heavy_check_mark: +41  225 :zzz: ±0  0 :x: ±0 

Results for commit e3a43173. ± Comparison against base commit ae9f3d64.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 91.60156% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 81.68%. Comparing base (ae9f3d6) to head (e3a4317).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238/graphs/tree.svg?width=650&height=150&src=pr&token=KrvyP8n7be&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) ```diff @@ Coverage Diff @@ ## master #1238 +/- ## ========================================== + Coverage 81.66% 81.68% +0.02% ========================================== Files 176 176 Lines 42565 42965 +400 Branches 4749 4782 +33 ========================================== + Hits 34760 35094 +334 - Misses 6584 6628 +44 - Partials 1221 1243 +22 ``` | [Files](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) | Coverage Δ | | |---|---|---| | [scalyr\_agent/agent\_main.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2FnZW50X21haW4ucHk=) | `57.81% <ø> (-0.41%)` | :arrow_down: | | [scalyr\_agent/builtin\_monitors/docker\_monitor.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2J1aWx0aW5fbW9uaXRvcnMvZG9ja2VyX21vbml0b3IucHk=) | `75.84% <100.00%> (-1.29%)` | :arrow_down: | | [scalyr\_agent/configuration.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2NvbmZpZ3VyYXRpb24ucHk=) | `94.66% <100.00%> (+<0.01%)` | :arrow_up: | | [scalyr\_agent/log\_processing.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2xvZ19wcm9jZXNzaW5nLnB5) | `86.99% <100.00%> (ø)` | | | [tests/unit/annotation\_config\_test.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-dGVzdHMvdW5pdC9hbm5vdGF0aW9uX2NvbmZpZ190ZXN0LnB5) | `100.00% <100.00%> (ø)` | | | [...unit/copying\_manager\_tests/copying\_manager\_test.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-dGVzdHMvdW5pdC9jb3B5aW5nX21hbmFnZXJfdGVzdHMvY29weWluZ19tYW5hZ2VyX3Rlc3QucHk=) | `98.14% <100.00%> (+0.25%)` | :arrow_up: | | [...ing\_manager\_tests/copying\_manager\_unittest\_test.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-dGVzdHMvdW5pdC9jb3B5aW5nX21hbmFnZXJfdGVzdHMvY29weWluZ19tYW5hZ2VyX3VuaXR0ZXN0X3Rlc3QucHk=) | `96.02% <100.00%> (+0.54%)` | :arrow_up: | | [...pying\_manager\_tests/copying\_manager\_worker\_test.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-dGVzdHMvdW5pdC9jb3B5aW5nX21hbmFnZXJfdGVzdHMvY29weWluZ19tYW5hZ2VyX3dvcmtlcl90ZXN0LnB5) | `98.36% <100.00%> (+<0.01%)` | :arrow_up: | | [tests/unit/log\_processing\_test.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-dGVzdHMvdW5pdC9sb2dfcHJvY2Vzc2luZ190ZXN0LnB5) | `99.33% <100.00%> (+<0.01%)` | :arrow_up: | | [scalyr\_agent/log\_watcher.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2xvZ193YXRjaGVyLnB5) | `64.71% <71.43%> (-8.02%)` | :arrow_down: | | ... and [4 more](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1238/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)
tomaz-s1 commented 6 months ago

Great work, especially with end to end tests.

I assume we plan add to some additional high level documentation (in addition to the "lower level" monitor documentation) here at some point as part of a separate repo - https://app.scalyr.com/help/scalyr-agent-k8s, right?

EDIT: Never mind, I see we already have a ticket for that.