search

scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 59 forks source link

Multi Dataset Account ChR #1256

Closed alesnovak-s1 closed 5 months ago

alesnovak-s1 commented 6 months ago

Implementation of: https://sentinelone.atlassian.net/browse/DTIN-3923

github-actions[bot] commented 6 months ago

Test Results

     20 files  ±0       20 suites  ±0   31m 47s :stopwatch: -42s 1 487 tests +1  1 467 :heavy_check_mark: +1    20 :zzz: ±0  0 :x: ±0  7 106 runs  +5  6 881 :heavy_check_mark: +5  225 :zzz: ±0  0 :x: ±0 

Results for commit 6ddd4efe. ± Comparison against base commit 023b3154.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. ``` tests.unit.builtin_monitors.kubernetes_monitor_test.ContainerCheckerTest ‑ test_check_containers_with_api_key_annotations ``` ``` tests.unit.builtin_monitors.kubernetes_monitor_multi_account_test.ContainerCheckerTest ‑ test_check_containers_with_api_key_annotations tests.unit.builtin_monitors.kubernetes_monitor_multi_account_test.ContainerCheckerTest ‑ test_check_namespace_change ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 69.23077% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 54.77%. Comparing base (023b315) to head (6ddd4ef).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256/graphs/tree.svg?width=650&height=150&src=pr&token=KrvyP8n7be&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) ```diff @@ Coverage Diff @@ ## master #1256 +/- ## =========================================== - Coverage 81.78% 54.77% -27.02% =========================================== Files 176 51 -125 Lines 42981 18666 -24315 Branches 4784 3294 -1490 =========================================== - Hits 35152 10223 -24929 - Misses 6600 7253 +653 + Partials 1229 1190 -39 ``` | [Files](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) | Coverage Δ | | |---|---|---| | [scalyr\_agent/copying\_manager/copying\_manager.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256?src=pr&el=tree&filepath=scalyr_agent%2Fcopying_manager%2Fcopying_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2NvcHlpbmdfbWFuYWdlci9jb3B5aW5nX21hbmFnZXIucHk=) | `67.19% <ø> (-20.00%)` | :arrow_down: | | [scalyr\_agent/monitor\_utils/k8s.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256?src=pr&el=tree&filepath=scalyr_agent%2Fmonitor_utils%2Fk8s.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L21vbml0b3JfdXRpbHMvazhzLnB5) | `67.28% <89.36%> (-14.02%)` | :arrow_down: | | [...calyr\_agent/builtin\_monitors/kubernetes\_monitor.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256?src=pr&el=tree&filepath=scalyr_agent%2Fbuiltin_monitors%2Fkubernetes_monitor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2J1aWx0aW5fbW9uaXRvcnMva3ViZXJuZXRlc19tb25pdG9yLnB5) | `57.07% <38.71%> (-12.92%)` | :arrow_down: | ... and [166 files with indirect coverage changes](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1256/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)