scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 59 forks source link

Fixing an issue with multi acount support. #1259

Closed alesnovak-s1 closed 5 months ago

alesnovak-s1 commented 5 months ago

When k8s_logs configuration is present, it used to be populated by default worker_id if none were present. This commit removes default worker_id, so it's up to CopyingManager to handle empty worker_id.

github-actions[bot] commented 5 months ago

Test Results

     20 files  ±  0       20 suites  ±0   31m 29s :stopwatch: -47s 1 485 tests  -   2  1 465 :heavy_check_mark:  -   2    20 :zzz: ±0  0 :x: ±0  7 096 runs   - 10  6 871 :heavy_check_mark:  - 10  225 :zzz: ±0  0 :x: ±0 

Results for commit 49739556. ± Comparison against base commit b514d715.

This pull request removes 2 tests. ``` tests.unit.builtin_monitors.kubernetes_monitor_multi_account_test.ContainerCheckerTest ‑ test_check_containers_with_api_key_annotations tests.unit.builtin_monitors.kubernetes_monitor_multi_account_test.ContainerCheckerTest ‑ test_check_namespace_change ```

:recycle: This comment has been updated with latest results.