scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 59 forks source link

DTIN-4234: Cleanup tox lint target #1264

Closed jmakar-s1 closed 5 months ago

jmakar-s1 commented 5 months ago
************* Module scalyr_agent.builtin_monitors.thread_pool
scalyr_agent/builtin_monitors/thread_pool.py:72:12: E1101: Instance of 'ExecutorMixIn' has no 'finish_request' member (no-member)
scalyr_agent/builtin_monitors/thread_pool.py:74:12: E1101: Instance of 'ExecutorMixIn' has no 'handle_error' member (no-member)
scalyr_agent/builtin_monitors/thread_pool.py:76:12: E1101: Instance of 'ExecutorMixIn' has no 'shutdown_request' member (no-member)
scalyr_agent/builtin_monitors/thread_pool.py:88:8: E1101: Super of 'ExecutorMixIn' has no 'server_close' member (no-member)
github-actions[bot] commented 5 months ago

Test Results

       8 files   -      12         8 suites   - 12   20m 42s :stopwatch: - 11m 20s 1 370 tests  -    115  1 280 :heavy_check_mark:  -    185  90 :zzz: +  70  0 :x: ±0  1 392 runs   - 5 704  1 302 :heavy_check_mark:  - 5 569  90 :zzz:  - 135  0 :x: ±0 

Results for commit c3e41024. ± Comparison against base commit 089af0f1.

This pull request removes 115 tests. ``` tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_checkpoints[process-1-1] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_checkpoints[process-2-2] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_checkpoints_consolidated_checkpoints[process-1-1] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_checkpoints_consolidated_checkpoints[process-2-2] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_failed_health_check_status_and_failed_worker[process-1-1] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_failed_health_check_status_and_failed_worker[process-2-2] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_generate_status[process-1-1] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_generate_status[process-2-2] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_health_check_status[process-1-1] tests.unit.copying_manager_tests.copying_manager_new_test.TestBasic ‑ test_health_check_status[process-2-2] … ```
This pull request skips 76 tests. ``` tests.unit.agent_main_test.AgentMainTestCase ‑ test_create_client_ca_file_and_intermediate_certs_file_doesnt_exist tests.unit.builtin_monitors.kubernetes_monitor_test.TestKubeletApi ‑ test_unverified_https tests.unit.builtin_monitors.kubernetes_monitor_test.TestKubernetesKubeletApiAuthTokenCaching ‑ test_kubelet_api_re_read_token_every_x_seconds tests.unit.builtin_monitors.kubernetes_monitor_test.TestKubernetesKubeletApiAuthTokenCaching ‑ test_kubernetes_api_re_read_token_every_x_seconds tests.unit.builtin_monitors.kubernetes_monitor_test.TestKubernetesKubeletApiAuthTokenCaching ‑ test_re_read_token_every_x_seconds tests.unit.builtin_monitors.linux_process_metrics_test.LinuxProcessMetricsMonitorTest ‑ test_gather_sample_by_commandline_success tests.unit.builtin_monitors.linux_process_metrics_test.LinuxProcessMetricsMonitorTest ‑ test_gather_sample_by_pid_failure_pid_doesnt_exist tests.unit.builtin_monitors.linux_process_metrics_test.LinuxProcessMetricsMonitorTest ‑ test_gather_sample_by_pid_success tests.unit.builtin_monitors.linux_system_metrics_test.LinuxSystemMetricsMonitorTest ‑ test_gather_sample_ignore_mounts tests.unit.builtin_monitors.linux_system_metrics_test.LinuxSystemMetricsMonitorTest ‑ test_gather_sample_success … ```

:recycle: This comment has been updated with latest results.

jmakar-s1 commented 5 months ago

Closing this PR and splitting it up into two