scalyr / scalyr-grafana-datasource-plugin

Apache License 2.0
14 stars 5 forks source link

DSET-1386: Do not set autoAlign for plot requests #111

Closed jmakar-s1 closed 1 year ago

jmakar-s1 commented 1 year ago

Ref #110

For LRQ plot requests do not set autoAlign (default false) & explicitly set the slices to the number of max data points specified by the query options. Setting autoAlign overrides the value specified by slices

@sergeysentinelone & @oleksiisentinelone Any potential problems with this change? Capped max data points to 10k to be on the safe side

Other minor, unrelated changes:

jmakar-s1 commented 1 year ago

Looks good to me, but would be great to have some tests coverage as well 😄

Yup, planning on going through the project to add a test suite later on

jmakar-s1 commented 1 year ago

@sergeysentinelone Does this api usage change look ok? Don't want to introduce something that would potentially impact database performance