search

scalyr / scalyr-logback

Scalyr support for Logback logging
Apache License 2.0
0 stars 1 forks source link

Mavenize the project into two sub modules for their respective jars #4

Closed tburch closed 8 years ago

tburch commented 9 years ago

I did a basic maven conversion of the project so that dependencies can be expressed. Deploying to Maven central (#3) should be fairly simple. The only todo is to set the version for scalyr-api in the parent pom.xml (it also needs to be uploaded to maven central):

      <dependency>
        <groupId>com.scalyr</groupId>
        <artifactId>scalyr-api</artifactId>
        <version><!-- whatever version exists in maven central --></version>
      </dependency>
czerwingithub commented 9 years ago

Hi Tristan -

Thanks very much for the pull request. I just wanted to touch base and let you know we received it, but we probably won't get a chance to respond to you until either the end of the week or early next week. Sorry for the delay, but we have a few urgent tasks we are finishing up and we want to get a chance to test this out properly.

-Steve

On Mon, Jun 15, 2015 at 10:15 AM, Tristan Burch notifications@github.com wrote:

I did a basic maven conversion of the project so that dependencies can be expressed. Deploying to Maven central (#3 https://github.com/scalyr/scalyr-logback/issues/3) should be fairly simple. The only todo is to set the version for scalyr-api in the parent pom.xml (it also needs to be uploaded to maven central):

  <dependency>
    <groupId>com.scalyr</groupId>
    <artifactId>scalyr-api</artifactId>
    <version><!-- whatever version exists in maven central --></version>
  </dependency>

You can view, comment on, or merge this pull request online at:

https://github.com/scalyr/scalyr-logback/pull/4 Commit Summary

  • Mavenize the project into two sub modules for their respective jars

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/scalyr/scalyr-logback/pull/4.