search

scambier / obsidian-no-dupe-leaves

Automatically switch the focus to open notes instead of reopening them
GNU Affero General Public License v3.0
59 stars 5 forks source link

Is it me, or does it straight up not work? #12

Closed Z3DT closed 1 year ago

Z3DT commented 1 year ago

With this plugin enabled, if I have something open in a tab already and then click a link to that file in another tab, I still get a duplicate tab. This happens both with tabs and with two side by side pages like in de gif in the plugin description.

Recording of it not working: https://www.youtube.com/watch?v=Tk0nbbTBO_0

scambier commented 1 year ago

I have just updated the plugin with a few corrections. Maybe that will fix your issue.

Z3DT commented 1 year ago

I have updated the plugin, but no change in behavior.

czottmann commented 1 year ago

Same here. Obsidian 1.3.4 on macOS.

scambier commented 1 year ago

It works on one of my vaults, but not the other 🤔 At least it's reproducible

czottmann commented 1 year ago

It works on one of my vaults, but not the other

The joys of software development, amirite 😂

scambier commented 1 year ago

Should be fixed (at least it passed my tests), you can reopen if that's not the case :)

czottmann commented 1 year ago

No dice, I'm afraid, 0.0.10 doesn't change anything for me. I've restarted Obs, then checked dev tools for errors (none).

scambier commented 1 year ago

Ok, can you give me reproduction steps I can apply on an empty vault please? Thank you!

czottmann commented 1 year ago

I just realized I am probably wrong to expect your plugin to work when using the hotkeys of PeriodicNotes etc. because the hotkeys likely use core functionality which you mentioned in the README. Correct?

If so, you can close the ticket again on my behalf, and I apologize for wasting your time.

scambier commented 1 year ago

👍 No problem. Yeah, the plugin only overwrites the openLinkText() function, which is called when clicking on links in notes. AFAIK it does not work with core plugins, and may or may not work with community plugins, depending on how they're built,