[BUG] Open result in new tab/pane not working on MacOS

scambier / obsidian-omnisearch

A search engine that "just works" for Obsidian. Supports OCR and PDF indexing.

GNU General Public License v3.0

1.14k stars 57 forks source link

[BUG] Open result in new tab/pane not working on MacOS #243

Closed pcuellar closed 2 months ago

pcuellar commented 1 year ago

Problem description:

When trying to open a note in a search list on a new tab/pane using the CTRL+SHIFT combination, it opens it in the same tab. I tried all possible combinations with SHIFT, CMD and CONTROL to no avail.

Your environment:

Omnisearch version: 1.14.0
Obsidian version: v1.3.1
Operating system: MacOS Ventura 13.4
Number of indexed documents in your vault (approx.): 500

Things to try:

Does the problem occur when Omnisearch is the only active community plugin: Yes
Does the problem occur when you don't index PDFs, images, or other non-notes files: Yes
Does the problem occur after a cache reset: Yes

cesar-programs commented 12 months ago

I am also experiencing this bug; CMD+Enter does not open in a new pane. Also on macOS Ventura 13.4

scambier commented 12 months ago

I don't own a Mac so can't test it.

Those are the related lines:

https://github.com/scambier/obsidian-omnisearch/blob/d651278b43c5df46accb6ffcf7ce981fe86902e6/src/components/modals.ts#L70-L86

https://github.com/scambier/obsidian-omnisearch/blob/d651278b43c5df46accb6ffcf7ce981fe86902e6/src/components/ModalVault.svelte#L97

According to Obsidian's API, "Mod = Cmd on MacOS and Ctrl on other OS"

scambier commented 2 months ago

Closing this as I can't reproduce. If the problem still exists on the latest versions of Obsidian & Omnisearch, please provide the following information:

Does it happen when Omnisearch is the only community plugin enabled?
Does it happen with another community plugin that uses the same cmd+enter combination?

Thank you.