scambier / obsidian-omnisearch

A search engine that "just works" for Obsidian. Supports OCR and PDF indexing.
GNU General Public License v3.0
1.25k stars 65 forks source link

[Bug] Issues with cm-chs-patch? #394

Open jiajiala opened 2 months ago

jiajiala commented 2 months ago

I tried to install the recommended Chinese plugin Word Splitting for Simplified Chinese in Edit Mode and Vim Mode

As a result of the test, the search results of the installation actually deteriorated It is a mistake to recommend Chinese users to install this additional supplement It made me miss Omnisearch many times I always thought that Omnisearch's support for Chinese was not good, so my search was incomplete However, this extra word segmentation plugin is actually the cause

If I hadn't caught this error, I still wouldn't be able to use Omnisearch

Thank you for making this excellent plugin

scambier commented 2 months ago

🤷‍♂️ Honestly I don't really have any opinion here as I've only done a few limited tests, and Chinese users seemed to be ok with this plugin.

Can I suggest you to poll other users (maybe on Obsidian's Discord server?) so they can give feedback here? If the plugin causes issues, I'll update the Readme accordingly.

(cc @aidenlx if you don't mind)

jiajiala commented 2 months ago

@scambier After testing Word Splitting for Simplified Chinese in Edit Mode and Vim Mode will improve some problems, but it will also create other problems I wonder if omnisearch can use the same search algorithm as obsidian's default The default algorithm has good support for Chinese

scambier commented 2 months ago

I wonder if omnisearch can use the same search algorithm as obsidian's default

Nope, totally different algorithms.