scanff / wiiradio

Automatically exported from code.google.com/p/wiiradio
3 stars 0 forks source link

Browser is always shown after closing Stream Info #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
WiiRadio version: 0.5

To reproduce the problem:
1. Click on "Playlists" or "Genre" on the menu bar at the top of the screen.
2. Press the "1" button to open the "Stream Info" dialog.
3. Press the "1" button again to close the "Stream Info" dialog.

The Browser is shown instead of the screen you were last looking at (ie.
"Playlists" or "Genre").

This is really a usability issue rather than a bug, but I find it annoying
nonetheless.

The problem code, I believe, lies in main.cpp at line 577:

    if (g_real_keys[SDLK_1] && !g_keys_last_state[SDLK_1])
    {

        if (g_screen_status != S_STREAM_INFO) {
            if (!visualize) g_screen_status = S_STREAM_INFO;
        }else if (g_screen_status == S_STREAM_INFO)  { g_screen_status =
S_BROWSER; }

    }

Consider saving the value of g_screen_status before displaying the stream
info, and restoring that value afterward.

I hope this helps! Thanks for a great app!

Original issue reported on code.google.com by prof1...@gmail.com on 21 Mar 2010 at 11:19

GoogleCodeExporter commented 9 years ago
Yes the entire screen status needs an overhaul and I need to save the previous 
state
so I can switch back to it.  I created Issue 49 to remind myself to do this. 

Original comment by iamsca...@gmail.com on 22 Mar 2010 at 3:10

GoogleCodeExporter commented 9 years ago
r141 fixed

Original comment by iamsca...@gmail.com on 22 Mar 2010 at 5:57