scania-digital-design-system / tegel

Tegel Design System
https://tegel.scania.com
MIT License
17 stars 13 forks source link

[Bug report]: tds-popover-menu not closing when triggering another tds-popover-menu to open #632

Closed jolalab closed 4 months ago

jolalab commented 4 months ago

Requirements before reporting

Package versions

@scania/tegel:1.8.0

Browser

Chrome

Framework

Angular

Version

Angular 17

Reproduction steps

  1. Add 2 tds-popover-menu component next to each other with 2 different triggers
  2. Click on the first one of them
  3. [The menu opens]
  4. Click on the second one
  5. [The other menu opens (but the first one does not close)]

Code example

.... ### Screenshots Add/Copy screenshot here ![Screenshot 2024-05-29 at 15 20 55](https://github.com/scania-digital-design-system/tegel/assets/164156972/509f42be-08bd-4561-92b1-be01834205d8) ### Expected behaviour When you have 1 menu open and trigger the other one to open, the first one should close ### Console errors Add warning/error message ### Contact information jonatan.lampa@scania.com
theJohnnyMe commented 4 months ago

I think I fixed this here: https://github.com/scania-digital-design-system/tegel/pull/595

Please check it, maybe you just need to bump version of Tegel to newer one as this one was released in 1.8.1

jolalab commented 4 months ago

Hey, thanks for pointing that out! I should have bumped to latest minor version also before reporting the bug, but thank you anyways! And great work! Appreciate your quick responses.

jolalab commented 4 months ago

Closing this one!