Closed HasanVatansever closed 3 months ago
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-651.d3fazya28914g3.amplifyapp.com
@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)
@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)
my two cents is that this naming follows the compactDesign
prop we have in table.
We are looking into designs at the moment to check if there is something to be aligned with the design. We will come back soon with more info.
@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)
i see naming is important and most difiicult part ;)
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@HasanVatansever and @mJarsater - I did update the code slightly.
I will show this to Laurens so he can double-check, but the code looks OK to me. Let's wait tomorrow for approval and merge then ;)
Describe pull-request
Adding "CompactDesign" property to make footer half size.
Issue Linking:
Choose one of the following options https://github.com/scania-digital-design-system/tegel/issues/650
How to test
Provide detailed steps for testing, including any necessary setup.
Checklist before submission
Suggested test steps
Screenshots
Additional context
Add any other context or feedback requests about the pull-request here.