scania-digital-design-system / tegel

Tegel Design System
https://tegel.scania.com
MIT License
17 stars 13 forks source link

feat(footer): add compact footer property #651

Closed HasanVatansever closed 3 months ago

HasanVatansever commented 3 months ago

Describe pull-request

Adding "CompactDesign" property to make footer half size.

Issue Linking:

Choose one of the following options https://github.com/scania-digital-design-system/tegel/issues/650

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to stroybook
  2. Check it in footer component

Checklist before submission

Suggested test steps

Screenshots

image

Additional context

Add any other context or feedback requests about the pull-request here.

aws-amplify-eu-north-1[bot] commented 3 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-651.d3fazya28914g3.amplifyapp.com

timrombergjakobsson commented 3 months ago

@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)

mJarsater commented 3 months ago

@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)

my two cents is that this naming follows the compactDesign prop we have in table.

theJohnnyMe commented 3 months ago

We are looking into designs at the moment to check if there is something to be aligned with the design. We will come back soon with more info.

HasanVatansever commented 3 months ago

@HasanVatansever hi and sorry for the slow response! We are having some internal discussion about naming :)

i see naming is important and most difiicult part ;)

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

theJohnnyMe commented 3 months ago

@HasanVatansever and @mJarsater - I did update the code slightly.

  1. Keep social icons on right if that is only slot used in that section
  2. Added controls for previewing how the footer would look without the start and end slots.

I will show this to Laurens so he can double-check, but the code looks OK to me. Let's wait tomorrow for approval and merge then ;)