feat(tds-table): added horizontal scroll

Lunkan89 commented 1 month ago

Describe pull-request

Describe what the pull-request is about

Issue Linking:

Choose one of the following options

Jira: Add ticket number after CDEP-: [CDEP-](https://tegel.atlassian.net/browse/CDEP-)
GitHub: Include issue link
No issue: Describe the problem being solved.

How to test

Provide detailed steps for testing, including any necessary setup.

Go to...
Check in...
Run ...

Checklist before submission

[ ] I have added unit tests for my changes (if applicable)
[X] All existing tests pass
[ ] I have updated the documentation (if applicable)

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components
[ ] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Screenshots

Include before/after screenshots for UI changes.

Additional context

Add any other context or feedback requests about the pull-request here.

aws-amplify-eu-north-1[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-657.d3fazya28914g3.amplifyapp.com

timrombergjakobsson commented 1 month ago

Maybe design should have a look at this as well? @charlottelorensson

Lunkan89 commented 3 weeks ago

After discussion with @theJohnnyMe and Laurens improvements we wanted to do was:

Only use one prop for activating horizontal scrolling ( horizontalScrollWidth is used now )
Have both footer and tooltip (if in the table) to be "sticky"
Create a separate story-test for horizontal scrolling to be able to fully test everything
Also being able to set column width when horizontal scroll i activated, not just when setting noMinWidth flag

Note: noMinWidth should still work to set width of columns, although i cannot use multiple conditionals for showing column width input on both horizontal scroll flag and minWidth flag. https://github.com/storybookjs/storybook/discussions/18542

Lunkan89 commented 3 weeks ago

The story includes both pagination and table tooltip, so there is some code duplication there. Any suggested improvements?

Lunkan89 commented 3 weeks ago

Accepted by design :)