scania-digital-design-system / tegel

Tegel Design System
https://tegel.scania.com
MIT License
17 stars 13 forks source link

fix: add missing type definitions #659

Closed lkritsimas closed 3 months ago

lkritsimas commented 3 months ago

Describe pull-request

Added type definitions that were missing when using modern TypeScript moduleResolution options, such as bundler.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to...
  2. Check in...
  3. Run ...

Checklist before submission

Suggested test steps

Screenshots

Include before/after screenshots for UI changes.

Additional context

I wasn't able to run the tests locally because of issues with Docker/WSL on my work laptop.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

aws-amplify-eu-north-1[bot] commented 3 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-659.d3fazya28914g3.amplifyapp.com

lkritsimas commented 3 months ago

Nice, could we make sure we do the same for the angular and core packages?

This is a change in the core package so it should apply to all packages that depend on it.

The issue that I created may be a bit misleading in hindsight. This should apply to any typescript project using modern module resolution options, however I only tried it out in a React+Vite project.