feat(grid): new grid - Githubissues

mistermalm commented 1 month ago

Describe pull-request

Implementation of new grid

Issue Linking:

Choose one of the following options

Jira: feat/CDEP-3314-new-grid

How to test

Go to Storybook
Check in Grid New
Resize window and/or toggle fluid.

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components

Additional context

No tests or component. We only ship CSS for new grid system.

aws-amplify-eu-north-1[bot] commented 1 month ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-663.d3fazya28914g3.amplifyapp.com

theJohnnyMe commented 4 weeks ago

Nice work! Wondering if it could be beneficial to separate the fluid and fixed examples in two different sub-stories?

Also thinking about the naming. It doesn't seem like the classnames collide with our old grid so that's great! Would it be feasible to simply rename this story to "Grid" and rename the old grid story to "DEPRECATED Grid"? Another alternative could be to name this story something like "TDS Grid" to differentiate them, but then we have an issue of inconsistencies between stories on a global level since no other story have that suffix. What do you think @timrombergjakobsson @theJohnnyMe?

I helped by pushing a new section "Deprecated", so we can push deprecated components and foundations there.

@mistermalm - I agree with Nathalie, maybe it is good to make separate stories for fixed and fluid grid. That also might mean removing argsso controls panel will be gone aka making more space on screen to test grid.

mistermalm commented 4 weeks ago

@theJohnnyMe @nathalielindqvist Sure could separate them, will double check with Laurens since it was his to combine them.

@theJohnnyMe Thanks for the deprecation push, I really liked it how the import ended up! Also good suggestion on removing the definition of rows, doesn't seem to be needed.