fix(table): sorting arrow default and direction correction - Githubissues

scania-digital-design-system / tegel

Tegel Design System

https://tegel.scania.com

MIT License

15 stars 12 forks source link

fix(table): sorting arrow default and direction correction #669

Closed theJohnnyMe closed 2 weeks ago

theJohnnyMe commented 3 weeks ago

Describe pull-request

Fixing two issue:

Missing default/unsorted icon back to unsorted columns
Changing arrow direction for asc and desc directions

Improvement:

Replacing hard-coded icons with icon components

Issue Linking:

Choose one of the following options

Jira: CDEP-3256
GitHub: https://github.com/scania-digital-design-system/tegel/issues/596

How to test

Open preview link, go to sortable table story
On initial state, all unsorted columns on hover should have icon with two arrows, one pointing down, one up to indicate this columns is sortable.
Clicking on header, ascending has arrow pointing up, descending has arrow pointing down.

Checklist before submission

[ ] I have added unit tests for my changes (if applicable)
[x] All existing tests pass
[ ] I have updated the documentation (if applicable)

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components
[ ] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Screenshots

Include before/after screenshots for UI changes.

Additional context

aws-amplify-eu-north-1[bot] commented 3 weeks ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-669.d3fazya28914g3.amplifyapp.com

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud