fix(dropdown): async data source handling

theJohnnyMe commented 2 months ago

Describe pull-request

If the dropdown does not have children, but the default option is set, it would throw a lot of errors in the console. Some users have an async way of adding data later to the component so they end up in errors even if their state is "normal". Now we stop processing in the early stage. Also lopping over dropdown items is improved.

Issue Linking:

Jira: Add ticket number after CDEP-: CDEP-3116

How to test

Open the preview link
Check if adding a default value works as expected in the component
Try to add more items to the dropdown during the lifetime (fun times in the console ahead :D )

Checklist before submission

[ ] I have added unit tests for my changes (if applicable)
[x] All existing tests pass
[ ] I have updated the documentation (if applicable)

Additional context

I might try to set up an example on one of the demo pages if needed.

github-actions[bot] commented 2 months ago

Playwright test results

passed 361 passed

Details

stats 361 tests across 111 suites
47.1 seconds
commit a29948c

aws-amplify-eu-north-1[bot] commented 2 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-707.d3fazya28914g3.amplifyapp.com