scania-digital-design-system / tegel

Tegel Design System
https://tegel.scania.com
MIT License
19 stars 14 forks source link

fix(text-field): counter label color in disabled state #845

Closed ckrook closed 4 days ago

ckrook commented 5 days ago

Describe pull-request

This PR address the color on the text field counter label when its disabled. Adding a more toned down grey color to it when its disabled.

Issue Linking:

CDEP-2669

How to test

  1. Go to aws storybook link
  2. Navigate to the textfield component
  3. Add an limit to the textfield text and toggle disabled controller to true.
  4. Make sure it works as intended.
  5. Also change to dark mode to make sure it looks good here as well.

Checklist before submission

Suggested test steps

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions[bot] commented 5 days ago

Playwright test results

passed  391 passed
skipped  1 skipped

Details

stats  392 tests across 132 suites
duration  53.4 seconds
commit  f852ca0

Skipped tests src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true
aws-amplify-eu-north-1[bot] commented 5 days ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-845.d3fazya28914g3.amplifyapp.com