search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Bug - File Upload Component #546

Closed Seanaseire closed 4 years ago

Seanaseire commented 4 years ago

Describe the bug
Due to the recent u80 of Chrome, the file upload component no longer works.

To Reproduce

  1. Create a webpage with file upload component implemented as such
<link  rel="import" href="https://static.scania.com/build/global/3.5.2/components/file-upload/file-upload.html">

<c-file-upload name="uxlib-file-input" multiple max-file-size="1000" accept="image/*"></c-file-upload>

Version of Corporate-ui
Version 3.5.5

Desktop information:

helloimela commented 4 years ago

Hello, thank you for reporting the issue! This problem appear probably caused by display='inline' attribute. Because file upload with drop area is working properly.

Unfortunately, we are limited in resources now and we decided to focus on the development of corporate-ui v4 which will provide a more sustainable & flexible solution since Polymer v1 which is used in corporate-ui 3 is not supported by Chrome and other major browsers. (You can see a warning in the console if you are still using corporate-ui 3). We strongly suggest everyone move to corporate-ui 4 and we would like to ask your help and the community to solve this issue together. If you think it is still valuable to fix this issue in corporate-ui 3, please help us fix this problem and create a pull-request.

Right now we have no plan to create file-upload component in CUI 4. If you think this feature (file upload component) is important and need to be implemented in corporate-ui 4, please contact our team! Or you can also develop the component yourself and contributing to the bigger community :)

Thanks! P.S. We will close this issue soon if we don't receive update from you or from others in this thread :)

helloimela commented 4 years ago

Hello @Seanaseire , any update on this issue? Is this a blocker in your project? As mentioned above, it will probably implemented in version 4 and not 3, if there are any request arise regarding file-upload component.

helloimela commented 4 years ago

A month ago we announced about deprecation of Corporate UI 3 in 1 year, we will only provide support for severe bugs. We will close this issue for now. Please check solution in Corporate UI 4 and if the problem appears, we will solve it in version 4. Link to annoucement in Teams: link