Bug - "JS errors breaks other Component(s) in the page"

[lchkux]

Describe the bug
There's an AEM Component that's failing to load in the www.scania.com website and one of the possible reasons could be because of the errors thrown from c-icon.system.entry.js file. This happens for a set of users who access the website in the Chrome version 71 in desktop and in version 11.1.2.2 on samsung internet in mobile. (www.scania.com)

To Reproduce

1. Go to www.scania.com via chrome version 71 on desktop or through a Samsung mobile browser
2. Scroll down to IN FOCUS section. You will notice the broken images in the Carousel component
3. Open the browser console to see the error

Expected behavior
The carousel component should load. Images should render properly.

Screenshots

Version of Corporate-ui
4.0.3-0

Framework and version
AEM 6.4

Application link
https://www.scania.com

Desktop information:

• Chrome
• Version 71

Smartphone information

• Device: Samsung
• Browser Chrome
• Version 11.1.2.2

[mmexvr]

Hi, thanks for the feedback. Does the same problem occur without corporate-ui and scania-theme? Hard to replicate the error at this time. Can you make sure it is caused by corporate-ui?

Seems to me it is a height problem with the component from the css? How is the height set for the slide component ?

Here are some generall anwsers: https://digitaldesign.scania.com/faqs/faq-development

[lchkux]

If it's the height problem how does it work in all browsers including IE? And the js errors in the console says it clearly comes out of your js file.

[lchkux]

Please fix the console errors coming from your js file in the above mentioned version of browsers.

[mmexvr]

Have you tried the suggestion from previous post I made?

[lchkux]

I don’t think its needed. As I said it’s specific to a version of chrome and Samsung. It works everywhere else.

You please fix the js console errors and let me know. If the errors are fixed and the issue still exists then I can conclude it’s a bug from my side.

But right now I want the errors from your js file to go away. Because a js file which throws errors has a huge impact on page performance.

[mmexvr]

I have looked at scania.com with chrome 71, The error only appear sometimes in that version. I can't replicate the error in a good way for debugging. Can you provide a good way for replicating the error, then we can look into it further. It might be something with the loading sequence for your application.

But regarding the slider. even if the error doesn't appear, it is still broken

if you add height manually for testing, you can see it is there

There is a new version of corporate-ui 4 also :) https://github.com/scania/corporate-ui/releases

[lchkux]

I have now added the height but still I see lots of errors in the console. Could you please fix?