search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Improvement - Avoid using scania specified icon in component code #567

Open helloimela opened 4 years ago

helloimela commented 4 years ago

Describe current situation
Some components used scania specified icon in components code. This can cause a problem if user did not use scania theme, e.g.: c-cookie, c-table

Describe the improvement
Possible solution:

  1. add public properties that will receive icon from outside or use variable for theme name
  2. add fallback if icon is not available

Might be related to this : #562