search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Bug - "Blank login page" #568

Closed Playmountain closed 4 years ago

Playmountain commented 4 years ago

Describe the bug
Users are greeted by a blank page when attempting to login using IE 11

ie11

To Reproduce
Steps to reproduce the behavior:

  1. Open IE 11
  2. Open developer console
  3. Visit https://fg.ciam.devtest.aws.scania.com/auth/realms/scania/protocol/openid-connect/auth?client_id=mupp_foo_client&redirect_uri=https://s3-eu-west-1.amazonaws.com/ciam-demo-app/index.html&response_type=token id_token&scope=email openid profile&nonce=foobarQ
  4. See blank page, note several 404 entries under the network tab

Expected behavior
Users should be greeted by a page allowing them to select which supported idp they wish to authenticate with

edge

Version of Corporate-ui
3.5.6-1

Framework and version
If you use any specific framework please provide information

Desktop information:
Please complete the following information

Additional context
Add any other context about the problem here. IE 11 tries to fetch various components using corrupted urls: ex webcomponents https://fg.ciam.devtest.aws.scania.com/auth/realms/scania/protocol/openid-connect/undefined/auth/resources/3naox/login/scania-corporate-ui/node_modules/webcomponents.js/webcomponents-lite.js Url should most likely be: https://fg.ciam.devtest.aws.scania.com/auth/resources/3naox/login/scania-corporate-ui/node_modules/webcomponents.js/webcomponents-lite.js Hard to tell if this is the problem or just a symptom of something else.

We are currently using the most recent, non-beta version of corporate-ui ,which provides the login component so we unable to upgrade to a later version.

Contact information CIAM team group mailbox: iam.maintenance@scania.com anders.x.ohlsson@scania.com tobias.rang@scania.com daniel.lekberg@scania.com

helloimela commented 4 years ago

The problem is possibly caused by this line in CUI https://github.com/scania/corporate-ui/blob/v3/Update_login_component/src/global/ts/core.ts#L140

  window['static_root'] = (wv.props ? JSON.parse(wv.props)['--root'] : undefined) || helpers.urlInfo(scriptUrl).origin;
  window['version_root'] = (window['static_root'] + helpers.urlInfo(scriptUrl).pathname).replace('/js/corporate-ui.js', '');

It only happens in IE though, maybe it cannot find wv.props Other solution could be, from your application, force-assign correct url in windows variable window['static_root'] = https://fg.ciam.devtest.aws.scania.com

IE image

Chrome image

helloimela commented 4 years ago

Fixed in #571 released in 3.5.6-2

Note: Please consider upgrade your project to use corporate-ui 4. We will drop support corporate-ui 3 in the future. The main reason is corporate-ui 3 is using Polymer v1 which is not a web standard and not widely supported by major browsers. Chrome drop support since April 2019. Right now it works using polyfill (webcomponents.js). But we never know when Chrome will drop support for the polyfill. For sustainable solution we strongly recommend to upgrade to version 4. . We can use template and not a login component, which is more flexible to maintain for your team. In addition, all UI updates will be released in version 4.