scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Issue-568: Use protocol and host to generate static_root #571

Closed Playmountain closed 4 years ago

Playmountain commented 4 years ago

Describe pull-request
This pull requests consists of a one-line change to how the static_root is set if wv.props does not contain the desired value. The helper script, which is the fallback if the value is missing from wv.props, returns an attribute called origin. This attribute for some reason is undefined when using IE 11. Chaining the protocol + '//' + host attributes instead provides an equivalent value to origin.

Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123) Fixes: #568

How to test
The solution to this issue is only testable from one of the member of the ciam team's machines. We have tested the login page locally after the fix was applied with the following browsers with positive results

Screenshots

Additional context