search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Bug - Problems to implement c-table with pre-release version #577

Closed gustavookamoto closed 4 years ago

gustavookamoto commented 4 years ago

I'm trying to use the new pre-release versions for corporate-ui and scania-theme installing via NPM, but when I execute the project, the component isn't building properly. I've tried to install in many different ways, but it's not working.

To Reproduce
uninstal the current version from your project and install both packages (corporate-ui 4.1.2-1 / scania-theme 1.1.3-1) via npm.

image

helloimela commented 4 years ago

Hello @gustavookamoto , could you provide more details, in which framework are you working on? I tried to reproduce in simple HTML script import, and also in angular, and it works fine.

image

helloimela commented 4 years ago

Do you receive any error message on the console window?

gustavookamoto commented 4 years ago

Hello, I'm using angular 9 and it's not displaying any error messages. I just uninstalled the old versions and installed using npm.

image

image

helloimela commented 4 years ago

Now I got the same error when trying in Angular 9. It seems like the styling from the theme is not rendered in a correct manner. Could be a problem with loading order or the way the view is rendered has changed in Angular 9 causing issues with CSS adopted stylesheet technique that we have in CUI. 🤔 @mmexvr

helloimela commented 4 years ago

Did some test and apparently it's an initiation problem. The line below shows the value of style is null sometimes. https://github.com/scania/corporate-ui/blob/984267950f5dcc799ae7bf39cf904049f0f3501b/src/helpers/themeStyle.ts#L12