scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Bug - Footer styling in FF, changing theme cause error with icons and html attribute #584

Closed mmexvr closed 3 years ago

mmexvr commented 3 years ago

Describe pull-request
Describe what the pull-request is about

Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123) Fixes: #582 fixes: #583

How to test
Add description how to test if possible

  1. Start a vue application for example our example in FF
  2. Look at the styling of the footer
  3. Try it all browser(new and old edge, FF...)

Seconding fix

  1. Start up the sdds application, try it all browser
  2. Switch theme between both no theme and for example MAN
  3. No error should be shown now, just a warning if there is no icons using another theme

Screenshots
If applicable, add screenshots to help explain

Additional context
Add any other context about the pull-request here.