search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Fixing display issues for the navbar within c-header #600

Closed olivermc94 closed 3 years ago

olivermc94 commented 3 years ago

Adding overflow: inherit; to be able to show the content withing the dropdown inside the navbar for c-header

Solving issue
This should solve the issue [Bug - "Content in dropdowns in is hidden within the navbar"]

Fixes: #599

helloimela commented 3 years ago

599

helloimela commented 3 years ago

Hello @olivermc94 thanks for the PR! I have tested the solution, unfortunately it still not solve the issue (see screenshot below) image

As you can see on the highlighted styling on the bottom right, overflow hidden comes from .navbar class in the header component, not navigation. I think this css comes from scania-theme, probably on this line https://github.com/scania/scania-theme/blob/a5def5b8e4cf42838b7d5adcfdb9e730147f583f/src/styles/elements/c-header.scss#L61 Can you try to change it in scania-theme instead and see if it works ? Thanks :)

helloimela commented 3 years ago

Related to https://github.com/scania/scania-theme/pull/165