search

scania / corporate-ui

This repo will be archived in Q3 2021, please visit https://github.com/scania-digital-design-system
https://digitaldesign.scania.com/
25 stars 15 forks source link

Bug - When screen is small, a white overlay is added #602

Open olivermc94 opened 3 years ago

olivermc94 commented 3 years ago

Describe the bug
When screen is small, a white overlay is added

Screenshots
image

Version of Corporate-ui
4.2.0-2

mmexvr commented 3 years ago

We need example how to replicate this error. Please don't skip the question added in the bug report, it gives us more information how to debug it.

For example here it works. https://codepen.io/corporate-ui/pen/OYmqpr

Thanks for feedback!

olivermc94 commented 3 years ago

This issue is visible when the screen is small and apparently when we dont have this 'Global' link in our header as the example you gave me on codepen.io. When i remove it through the inspector, i can see the same white space. image

When removing the element link: Without opacity image

With opacity image

helloimela commented 3 years ago

@olivermc94 That is correct, and expected style for navigation right now. When you click on the navigation hamburger menu, navigation will open, the navigation itself will cover up the whole page on mobile and content should be hidden. When you click the hamburger menu again, navigation is closed, and user can see the content. I think it is a similar behavior in Corporate UI 3 as well. But as we mention before, the interaction and UX for navigation is receiving some updates. But for now, that is the correct behavior. Screenshot below shows how it should looks like on mobile:

Navigation close: image

Navigation open: image