search

scanner-research / scanner

Efficient video analysis at scale
https://scanner-research.github.io/
Apache License 2.0
615 stars 108 forks source link

Is enum34 necessary? #241

Closed keunhong closed 5 years ago

keunhong commented 5 years ago

enum34 is installed in the docker image, but the docker image uses Python 3.5. This clashes with the build-in enum library and breaks some packages (e.g. pipenv).

The dependency is listed here: https://github.com/scanner-research/scanner/blob/master/docker/ubuntu16.04/requirements.txt#L9

fpoms commented 5 years ago

We don't use that anymore, thanks for pointing it out!

Just pushed a commit with the package removed from the requirements file. The docker image should be updated in ~1 hour after the automated tests finish.