op histogram doesn't exist

photoszzt commented 5 years ago

I'm running the Walkthrough.ipynb from docker image provided. I hit the following error:

---------------------------------------------------------------------------
ScannerException                          Traceback (most recent call last)
<ipython-input-7-c772bdec7cda> in <module>()
      1 frame = sc.io.Input([stream])
----> 2 histogram = sc.ops.Histogram(
      3     frame = frame,
      4     device = DeviceType.CPU) # Change this to DeviceType.GPU if you have a GPU
      5 output = NamedStream(sc, 'example_hist')

/usr/local/lib/python3.5/dist-packages/scannerpy/op.py in __getattr__(self, name)
    164 
    165         # This will raise an exception if the op does not exist.
--> 166         op_info = self._sc._get_op_info(name)
    167 
    168         if (not orig_name in PYTHON_OP_REGISTRY and

/usr/local/lib/python3.5/dist-packages/scannerpy/client.py in _get_op_info(self, op_name)
    431 
    432             if not op_info.result.success:
--> 433                 raise ScannerException(op_info.result.msg)
    434 
    435             self._op_cache[op_name] = op_info

ScannerException: Op Histogram does not exist

willcrichton commented 5 years ago

Thanks for raising an issue @photoszzt. This should be fixed now in 3a0f25822306aea18595ed2ca0b06c3b176db4c6. Can you pull the docker image again and double check?

photoszzt commented 5 years ago

It seems the latest docker image doesn't contain your update. Maybe I'm pulling the wrong time. I apply your modification manually and it works.

willcrichton commented 5 years ago

Ah looks like that was an upstream issue in scannertools, which should be fixed now as well.

scanner-research / scanner

op histogram doesn't exist #274