scanner-research / scanner

Efficient video analysis at scale
https://scanner-research.github.io/
Apache License 2.0
615 stars 108 forks source link

Fix HEVC inplace indexing #287

Closed jpablomch closed 4 years ago

jpablomch commented 4 years ago

This PR fixes an issue when passing encoded data to the decoder initialization. Previously, encoded data didn't include format information, which was causing errors when indexing HEVC video using Hwang.

The PR also propagates the use of HEVC descriptor to other places in the code.

Thanks!

fpoms commented 4 years ago

@jpablomch please rebase on top of master and then it should be good to go for merge!

jpablomch commented 4 years ago

Thanks, @apoms! Done!

On Sun, Sep 15, 2019 at 12:29 PM Fait Poms notifications@github.com wrote:

@jpablomch https://github.com/jpablomch please rebase on top of master and then it should be good to go for merge!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scanner-research/scanner/pull/287?email_source=notifications&email_token=AABIK3BKEPJYXOCZCZ7O6LDQJ2EITA5CNFSM4IW3RFP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XXK5I#issuecomment-531592565, or mute the thread https://github.com/notifications/unsubscribe-auth/AABIK3CYZK3JX4VDYW7ZAR3QJ2EITANCNFSM4IW3RFPQ .

fpoms commented 4 years ago

This is awesome! Thanks @jpablomch