search

scanny / python-pptx

Create Open XML PowerPoint documents in Python
MIT License
2.44k stars 528 forks source link

setup's `license` parameter should be a short string #748

Closed sschuberth closed 1 year ago

sschuberth commented 3 years ago

Currently, setup's license is set to the full text of the MIT license as read from the LICENSE file:

https://github.com/scanny/python-pptx/blob/71d1ca0b2b3b9178d64cdab565e8503a25a54e0b/setup.py#L26 https://github.com/scanny/python-pptx/blob/71d1ca0b2b3b9178d64cdab565e8503a25a54e0b/setup.py#L41 https://github.com/scanny/python-pptx/blob/b31cf20fe31ff0f3fe0c919111f3562bb58f8b1e/setup.py#L77

This is wrong as "license" should be a short string and should just contain the name of the license (ideally as an SPDX ID; so here just "MIT"), not its text.

scanny commented 3 years ago

Sounds good to me. I'll fix that up next time I'm in there :)

scanny commented 1 year ago

Fixed in version 0.6.22 circa Aug 20, 2023.