search

scanoss / webhook

This is the repository of the SCANOSS webhook
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Long comments may be rejected by gitlab #12

Closed simsandyca closed 11 months ago

simsandyca commented 1 year ago

The GitLabRequestHandler passes commit comments using params=comment which can create very long request URLs to gitlab. If the comment is very long gitlab api will reject the request and you lose the comment.

I fixed it to switching requests.post calls to pass json=comment .

simsandyca commented 1 year ago

Here's a PR with my fix https://github.com/scanoss/webhook/pull/13