search

scanse / sweep-ros

Scanse Sweep ROS Driver and Node
MIT License
68 stars 62 forks source link

topic as configurable ROS parameter; sample rate as configurable ROS … #8

Closed dheera closed 7 years ago

dheera commented 7 years ago
kent-williams commented 7 years ago

Thanks for adding this Dheera! I'll add these params to the launch files and get it merged.

sevenbitbyte commented 7 years ago

Generally speaking ROS systems simply use remapping so every package does not have to re-implement a topic name-change feature.

Conceptually speaking: http://wiki.ros.org/Names#Remapping On the command line: http://wiki.ros.org/Remapping%20Arguments In a launch file: http://wiki.ros.org/roslaunch/XML/remap

kent-williams commented 7 years ago

Agree with @sevenbitbyte, I removed the topic param.