search

scanse / sweep-sdk

Sweep SDK
MIT License
90 stars 85 forks source link

[libsweep] Forward errors from accumulate_scans to get_scan #87

Closed MikeGitb closed 7 years ago

MikeGitb commented 7 years ago

Scope of changes

Forward errors from accumulate_scans to get_scan.

Also adds an additional function that allows to cancel a read from a different thread, but doesn't expose this in the API

Known Limitations

Doesn't address the more fundamental question, if an error inside accumulate_scans should actually stop the worker thread and how the user is supposed to restart it.

MikeGitb commented 7 years ago

Closing this for now - I think the worker thread should handle errors gracefully and not just die on the user