Error propagation - Githubissues

MikeGitb commented 7 years ago

~~### Not yet tested! (RFC)~~

Scope of changes

Propagates exceptions occuring in the worker thread to sweep_device_get_scan.

Modifies queue code to play nice with move-only types
Manages dynamically allocated memory via unqiue_ptr as long as possible to prevent any memory leaks
Combines pointer to scan and exception pointer (one of them being nullptr) into one struct and passes them through the queue
Removes some redundant type defs accross the code base for consistency reasons (ccan drop that commit from the PR if prefered)

Known Limitations

~~Not yet tested (seeking early feedback)~~
Actual error handling (instead of just reporting) might be desired (see https://github.com/scanse/sweep-sdk/issues/91)

dcyoung commented 7 years ago

builds and runs just fine for me under normal conditions, but I haven't had a chance to test the actual error propagation yet. I'll try to induce or simulate some errors tomorrow and check that everything works.

dcyoung commented 7 years ago

Sorry for the delay. I wasn't able to get a device to error (that's a good thing in most cases haha ), but manually throwing an exception in accumulate scans definitely propagates through. So its looking good to me. @daniel-j-h any comments? if not I'll merge this in.

dcyoung commented 7 years ago

@MikeGitb can you rebase/fix merge conflicts on master and I'll merge this.

MikeGitb commented 7 years ago

done

dcyoung commented 7 years ago

Merged. Thanks!

scanse / sweep-sdk

Error propagation #93

Scope of changes

Known Limitations