search

scapegoat-scala / sbt-scapegoat

sbt plugin for scapegoat scala static analysis plugin
Apache License 2.0
140 stars 34 forks source link

Exception when compiling #175

Closed sjoerdmulder closed 8 months ago

sjoerdmulder commented 8 months ago

Updating to the latest version of scapegoat is causing a crash:

[error] ## Exception when compiling 571 sources to /home/sjoerd/project/core/target/scala-2.13/scapegoat-classes
[error] org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 49; Attribute name "T" associated with an element type ":" must be followed by the ' = ' character.
[error] java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)
[error] java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:178)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1465)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanAttribute(XMLDocumentFragmentScannerImpl.java:1505)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1363)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2726)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:605)
[error] java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:542)
[error] java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:889)
[error] java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:825)
[error] java.xml/com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
[error] java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1224)
[error] java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:637)
[error] scapegoat.xml.parsing.FactoryAdapter.loadDocument(FactoryAdapter.scala:141)
[error] scapegoat.xml.factory.XMLLoader.loadDocument(XMLLoader.scala:65)
[error] scapegoat.xml.factory.XMLLoader.loadDocument$(XMLLoader.scala:65)
[error] scapegoat.xml.XML$.loadDocument(XML.scala:61)
[error] scapegoat.xml.factory.XMLLoader.loadStringDocument(XMLLoader.scala:73)
[error] scapegoat.xml.factory.XMLLoader.loadStringDocument$(XMLLoader.scala:73)
[error] scapegoat.xml.XML$.loadStringDocument(XML.scala:61)
[error] scapegoat.xml.factory.XMLLoader.loadString(XMLLoader.scala:85)
[error] scapegoat.xml.factory.XMLLoader.loadString$(XMLLoader.scala:85)
[error] scapegoat.xml.XML$.loadString(XML.scala:61)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.decorateCode(HtmlReportWriter.scala:145)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.$anonfun$warnings$1(HtmlReportWriter.scala:125)
[error] scala.collection.immutable.List.map(List.scala:250)
[error] scala.collection.immutable.List.map(List.scala:79)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.warnings(HtmlReportWriter.scala:107)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.body(HtmlReportWriter.scala:103)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.toHTML(HtmlReportWriter.scala:141)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.generate(HtmlReportWriter.scala:147)
[error] com.sksamuel.scapegoat.io.ReportWriter.write(ReportWriter.scala:22)
[error] com.sksamuel.scapegoat.io.ReportWriter.write$(ReportWriter.scala:19)
[error] com.sksamuel.scapegoat.io.HtmlReportWriter$.write(HtmlReportWriter.scala:11)
[error] com.sksamuel.scapegoat.io.IOUtils$.writeHTMLReport(IOUtils.scala:13)
[error] com.sksamuel.scapegoat.ScapegoatComponent$$anon$1.$anonfun$run$1(plugin.scala:95)
[error] com.sksamuel.scapegoat.ScapegoatComponent.$anonfun$writeReport$1(plugin.scala:65)
[error] com.sksamuel.scapegoat.ScapegoatComponent.$anonfun$writeReport$1$adapted(plugin.scala:64)
[error] scala.Option.foreach(Option.scala:437)
[error] com.sksamuel.scapegoat.ScapegoatComponent.writeReport(plugin.scala:64)
[error] com.sksamuel.scapegoat.ScapegoatComponent$$anon$1.run(plugin.scala:95)
[error] scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1546)
[error] scala.tools.nsc.Global$Run.compileUnits(Global.scala:1530)
[error] scala.tools.nsc.Global$Run.compileSources(Global.scala:1522)
[error] scala.tools.nsc.Global$Run.compileFiles(Global.scala:1635)
[error] scala.tools.xsbt.CachedCompiler0.run(CompilerBridge.scala:176)
[error] scala.tools.xsbt.CachedCompiler0.run(CompilerBridge.scala:139)
[error] scala.tools.xsbt.CompilerBridge.run(CompilerBridge.scala:43)
[error] sbt.internal.inc.AnalyzingCompiler.compile(AnalyzingCompiler.scala:91)
[error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$7(MixedAnalyzingCompiler.scala:193)
[error] scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[error] sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:248)
[error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$4(MixedAnalyzingCompiler.scala:183)
[error] sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$4$adapted(MixedAnalyzingCompiler.scala:163)
[error] sbt.internal.inc.JarUtils$.withPreviousJar(JarUtils.scala:239)
[error] sbt.internal.inc.MixedAnalyzingCompiler.compileScala$1(MixedAnalyzingCompiler.scala:163)
[error] sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:211)
[error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:534)
[error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:534)
[error] sbt.internal.inc.Incremental$.$anonfun$apply$5(Incremental.scala:180)
[error] sbt.internal.inc.Incremental$.$anonfun$apply$5$adapted(Incremental.scala:178)
[error] sbt.internal.inc.Incremental$$anon$2.run(Incremental.scala:464)
[error] sbt.internal.inc.IncrementalCommon$CycleState.next(IncrementalCommon.scala:116)
[error] sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:56)
[error] sbt.internal.inc.IncrementalCommon$$anon$1.next(IncrementalCommon.scala:52)
[error] sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:263)
[error] sbt.internal.inc.Incremental$.$anonfun$incrementalCompile$8(Incremental.scala:419)
[error] sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:506)
[error] sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:406)
[error] sbt.internal.inc.Incremental$.apply(Incremental.scala:172)
[error] sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:534)
[error] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:488)
[error] sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332)
[error] sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:425)
[error] sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137)
[error] sbt.Defaults$.compileIncrementalTaskImpl(Defaults.scala:2371)
[error] sbt.Defaults$.$anonfun$compileIncrementalTask$2(Defaults.scala:2321)
[error] sbt.internal.server.BspCompileTask$.$anonfun$compute$1(BspCompileTask.scala:31)
[error] sbt.internal.io.Retry$.apply(Retry.scala:47)
[error] sbt.internal.io.Retry$.apply(Retry.scala:29)
[error] sbt.internal.io.Retry$.apply(Retry.scala:24)
[error] sbt.internal.server.BspCompileTask$.compute(BspCompileTask.scala:31)
[error] sbt.Defaults$.$anonfun$compileIncrementalTask$1(Defaults.scala:2319)
[error] scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:63)
[error] sbt.std.Transform$$anon$4.work(Transform.scala:69)
[error] sbt.Execute.$anonfun$submit$2(Execute.scala:283)
[error] sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:24)
[error] sbt.Execute.work(Execute.scala:292)
[error] sbt.Execute.$anonfun$submit$1(Execute.scala:283)
[error] sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] sbt.CompletionService$$anon$2.call(CompletionService.scala:65)
[error] java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
[error] java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[error] java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[error] java.base/java.lang.Thread.run(Thread.java:840)
[error]            
[error] stack trace is suppressed; run last core / Scapegoat / compileIncremental for the full output
[error] (core / Scapegoat / compileIncremental) org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 49; Attribute name "T" associated with an element type ":" must be followed by the ' = ' character.

Tried attaching a debugger on it and it seems it fails on the following string (found going up the stack to scapegoat.xml.factory.XMLLoader.loadDocument):

<span>Type bound resolves to <code>Nothing <: T <: Any</code>. Did you mean to put in other bounds?</span>

sjoerdmulder commented 8 months ago

Found a workaround for now; disable inspection on PointlessTypeBounds

Johnnei commented 8 months ago

Thanks for the report. I've raised a PR to scapegoat to fix the HTML report generation.