search

scapegoat-scala / scapegoat

Scala compiler plugin for static code analysis
Apache License 2.0
517 stars 88 forks source link

Hacktoberfest #433

Closed mccartney closed 3 years ago

mccartney commented 3 years ago

I know this has become controversial this year, but I continue to support Hacktoberfest. For contributors to come, we need to add hacktoberfest to one of list of this repo's topics (an opt-in this time).

Otherwise it says:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate.

Up to you @sksamuel, but I'd suggest we add that. I can take care of (majority) of the input flow here, even we encounter spam, which I don't think would be the case.

sksamuel commented 3 years ago

Why is it controversial?

On Sun, 4 Oct 2020, 12:29 Greg Oledzki, notifications@github.com wrote:

Assigned #433 https://github.com/sksamuel/scapegoat/issues/433 to @sksamuel https://github.com/sksamuel.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/sksamuel/scapegoat/issues/433#event-3837772620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGTZ73WHJ7HK33SATW3SJCWFZANCNFSM4SD2SZ4Q .

mccartney commented 3 years ago

The project has received some (partly) bad press this year. It's been said it allegedly does more harm than good, incl. encouraging spam pull requests (meaningless PRs which fix a single character or so) adding burden to the open source maintainers (I don't agree with this opinion though).

sksamuel commented 3 years ago

I think anything that encourages people to get involved is good. If someone wants to waste their time making pointless PRs, then so be it, reflects badly on them, not others.

On Sun, 4 Oct 2020 at 14:56, Greg Oledzki notifications@github.com wrote:

The project has received some (partly) bad press this year. It's been said it allegedly does more harm than good, incl. encouraging spam pull requests (meaningless PRs which fix a single character or so) adding burden to the open source maintainers (I don't agree with this opinion though).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sksamuel/scapegoat/issues/433#issuecomment-703307478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGQU4S6IDJKZULIZFF3SJDHQHANCNFSM4SD2SZ4Q .

sksamuel commented 3 years ago

I've added hacktoberfest and hacktoberfest2020 to the topics.