Open Kimplul opened 2 years ago
0k, created a new branch where I merged the patches applied over the last months to the mainline kernel here. I've also changed the the name of the module to reflect the one used in Linux although the Makefile continues to generate hid-tminit.ko
.
It seems to work for me, let me know if you have any problems. In the next days I'll send a patch to Mr Torvalds.
Also. I was thinking what's the point in having
{0x02, 0x00, 0x0005, "Thrustmaster T300RS (Missing Attachment)"},
{0x02, 0x03, 0x0005, "Thrustmaster T300RS (F1 attachment)"},
{0x02, 0x06, 0x0005, "Thrustmaster T300RS"},
{0x02, 0x09, 0x0005, "Thrustmaster T300RS (Open Wheel Attachment)"},
{0x02, 0x04, 0x0005, "Thrustmaster T300 Ferrari Alcantara Edition"},
if they all have the same value to switch and the init code uses the first one it finds anyway (?) Maybe I'll add some code to look for the wheel's specific attachment and if it fails it uses the first or the last
Also. I was thinking what's the point in having ...
I wouldn't be surprised if there was some wheel that required a different code depending on which attachment it has, so I'm not convinced it's a good idea to just remove that info altogether. Murphy's Law and all that.
Choosing the best match seems like a good idea though.
Hello again, would it be worth resubmitting the patch to the kernel? Seems to have been ignored last time around.
Hey, @scarburato just if you have details on the mailing list to push this latest changes, I can give a try and try to push on it
Hi, the module currently in the kernel isn't up to date with this repository, and I think we should patch it. Apparently some discontinuity can happen if the kernel is updated and it switches from
hid-tminit
tohid-thrustmaster
:https://github.com/Kimplul/hid-tmff2/issues/35
Last time you sent in the patch, would you like to do it again or do you want me to do it?