scaredyfish / blender-rhubarb-lipsync

Blender Rhubarb Lipsync is an addon for Blender integrating Rhubarb Lip Sync to automatically generate mouth-shape keyframes from a pose library.
187 stars 33 forks source link

Rhubarb can't be installed in Blender 3.0 #32

Closed Endertainer closed 2 years ago

Endertainer commented 2 years ago

So I tried to install the rhubarb addon but it gives me this error instead. image I'm using Blender 3.0.

scaredyfish commented 2 years ago

Thanks for letting me know. Looks like there was a minor API change - it should be an easy fix, I'll try to get to it soon.

Endertainer commented 2 years ago

OK. Let me know when a patch is release.

ShockBock commented 2 years ago

Thanks for your efforts, scaredyfish. This could be a 3.0-wide problem, as I can't install Rhubarb into the new update either. I think this error message is pretty much the same as experienced by Endertainer

Rhub_error

nicholasekubi commented 2 years ago

Thank you soo much for this

masonj19 commented 2 years ago

You can fix the error by changing line 13 in prefs_blender_rhubarb.py from default=bpy.utils.user_resource('SCRIPTS', "addons") + '/blender-rhubarb-lipsync/bin/rhubarb' + ('.exe' if system() == 'Windows' else '') to default=bpy.utils.user_resource('SCRIPTS', path="addons") + '/blender-rhubarb-lipsync/bin/rhubarb' + ('.exe' if system() == 'Windows' else '')

The necessary change is adding path= to the second argument of bpy.utils.user_resource.

The 2nd & 3rd args in bpy.utils.user_resource were changed to keyword only arguments as noted here: https://wiki.blender.org/wiki/Reference/Release_Notes/3.0/Python_API#Blender_3.0:_Python_API

There may still be other issues. I haven't done much testing with it yet.

Endertainer commented 2 years ago

default=bpy.utils.user_resource('SCRIPTS', path="addons") + '/blender-rhubarb-lipsync/bin/rhubarb' + ('.exe' if system() == 'Windows' else '')

I tried adding the patch and it works. image

ShockBock commented 2 years ago

Was able to get Rhubarb installed thanks to masonj19's fix. Good work sir!

Not tested the plugin beyond successful installation yet, but this looks promising

ShockBock commented 2 years ago

Rhubarb post install error

This is the error message I got when I test-ran the post-patch (c/o mason's fixj19's fix) Rhubarb just now to do some lip synching. Looks like we're not out of the woods yet. I'm running Blender on Ubuntu (Linux) in case that makes a difference

Endertainer commented 2 years ago

This is the error message I got when I test-ran the post-patch (c/o mason's fixj19's fix) Rhubarb just now to do some lip synching. Looks like we're not out of the woods yet. I'm running Blender on Ubuntu (Linux) in case that makes a difference

masonj19 fixes were meant for the windows version. Maybe that's why it doesn't work. Also, do you have an issue with the unmodified version?

scaredyfish commented 2 years ago

Thanks for the fix @masonj19, this fix is now incorporated into the latest release at https://github.com/scaredyfish/blender-rhubarb-lipsync/releases

@ShockBock I think you have a different issue. The error message says it can't find the Rhubarb binary - this is installed in the release linked above, but won't be there if you just cloned the repo.

ShockBock commented 2 years ago

Great work folks. Have reinstalled, this time with Rhubarb 3.0.2 for Linux and have generated some lip syncing key-frames using the tool. Seems to be back up and working 100%. Thanks for your efforts!

I've been key-framing for dialogue the old fashioned way over the past couple of days whilst Rhubarb was unavailable. Let's just say I'm appreciating the plug-in, now that it's working again, more than ever!