scarfacedeb / rails_admin_globalize_field

Tabbed interface and custom field type for globalize translations for Rails_admin
MIT License
51 stars 61 forks source link

Fixed bug when creating new translations #16

Closed sonxurxo closed 9 years ago

sonxurxo commented 9 years ago

Hi

This PR fixes a bug that was causing the lib not to show existing translations but to clear them, neither when creating new model instances nor when editing an existing one.

scarfacedeb commented 9 years ago

@sonxurxo Hi. I don't see how it would change the logic of that code. I tried to reproduce your issue, but to no avail.

As I see it, the only way it could clear the transactions is if I18n.available_locales would return array of strings. But I checked that theory and even if I set config.i18n.available_locales = ['en', 'cz'] # strings, I18n would coerce them into symbols anyway.

Could you provide a context for your issue? Reproducible example would be the best way to determine what goes wrong.

sonxurxo commented 9 years ago

Hi @scarfacedeb

Sorry, it happened a few weeks ago, and currently I don't have any time to work on this issue (I'm kind of new to Ruby on Rails and it would take a time I don't have right now...). I'll bookmark this thread and try to provide you with the context of the error ASAP. Sorry again for the inconvenience, and thank you for your work and effort

scarfacedeb commented 9 years ago

@sonxurxo no problem! 🎉 I'll close this issue for now. Feel free to reopen it.