scarlatti / roseingrave

Massively scalable musical source comparator
https://pypi.org/project/roseingrave/
2 stars 1 forks source link

Extending spreadsheets silently fails when user doesn't have permission #23

Open jlumbroso opened 1 year ago

jlumbroso commented 1 year ago

Scenario: I created the sheets for this project (lumbroso@princeton.edu) and, for the first time, another team member was attempting to extend them (@jaspervanderklis).

In our first attempt, we forgot to use the --extend flag, and so the program normally starting creating spreadsheets. ✅

In our second attempt, we used --extend and the program hung at this log step":

2023-05-31 19:05:04.803 | DEBUG I roseingrave.create_sheet:populate_spreadsheets:177 - Working on volunteer "amc5@juilliard.edu"

This step was hanging because @jaspervanderklis did not have the proper permissions to access the existing spreadsheet that I had previously created through past uses of the tool.

Correction: It would be create for the populate_spreadsheets to check for this edge case when extending an existing spreadsheet (i.e., when extending existing spreadsheet, check whether the user we are accessing as has proper authorization, and if so notify through the log).

Screenshot 2023-05-31 at 1 09 55 PM

josephlou5 commented 1 year ago

That's interesting. Was there anything special / different about the sharing status of the spreadsheet you tried to access? According to the open_spreadsheet() function, it should be able to detect when the user does not have permission to view or access the spreadsheet. I'm not sure why it would hang instead of throwing the appropriate error.