search

scarlehoff / pyHepGrid

Tool for distributed computing management geared towards HEP applications.
GNU General Public License v3.0
6 stars 4 forks source link

Stop allowing incompatible options at runtime #21

Closed DWalker487 closed 5 years ago

DWalker487 commented 5 years ago

Currently we can do e.g.

pyHepGrid run runcards/runcard.py -Dk

where asking to kill runs when submitting will be ignored but not throw an error. IMO the best behaviour is to make this error our. The fix would need to be an update to option handling in argument_parser.py to disallow incompatible args at the same time.

Similarly when two allowed options are selected, such as

pyHepGrid man runcards/runcard.py -D -s -p

only one will be run (but there's no rhyme or reason as to which one it will be. This is controlled by the order of precedence/if statements in main_routines.py. IMO an error should also be thrown in this case as well for consistency.

DWalker487 commented 5 years ago

See #23, commit 72150fef0982bdfd55c9a9f0242220a97af04678 where I've removed interdependences. Seems to run ok.