scarlehoff / pyHepGrid

Tool for distributed computing management geared towards HEP applications.
GNU General Public License v3.0
6 stars 4 forks source link

Runscripts are not python 2.4 compatible #48

Closed scarlehoff closed 4 years ago

scarlehoff commented 4 years ago

I was having a quick look at the runscripts and noticed that they are using the format string method. This was backported to python 2 but only down to 2.6.

So either the comment

try to keep this all python2.4 compatible. It may fail at some nodes otherwise :(

is not true anymore or the scripts will fail because of that.

I would also refrain from using print without the (). I doubt you will find any node where python 3 is the default but you never know.

jcwhitehead commented 4 years ago

Thanks for this Juan, I was aware of some code that might not work in older versions but had forgotten about .format(). Do you remember which nodes had python version <2.7?

scarlehoff commented 4 years ago

Don't remember but it was some of the CentOS 5 (5.X, don't remember the X) which had python 2.4 as default.

Closed with #49