search

scarlehoff / pyHepGrid

Tool for distributed computing management geared towards HEP applications.
GNU General Public License v3.0
6 stars 4 forks source link

flake8 too restrictive? #77

Closed scarlehoff closed 4 years ago

scarlehoff commented 4 years ago

A change in the readme made flake8 to fail... and it was passing a month ago.

I guess there was some update for flake that introduced the problem but I don't think the passing (or not) of the test should rely on external tools updating the way we like it...

jcwhitehead commented 4 years ago

Looking at these, I'm surprised flake's tests ever passed!

If flake keeps noticing new problems and they start to seem superficial or trivial, I'd support relaxing its settings, but these look like good things to have had flagged up. Not sure when we'd have noticed some of them otherwise.

marianheil commented 4 years ago

So its this CI that failed, compared to this.

Seems like flake8 updated to 3.8.2 which now uses new errors from pyflakes 2.2.0 and also pycodestyle updated to 2.6.0 which added the new warning E225.

For pycodestyle using Black (e.g. #71) might do the trick. pyflakes on the other hand catches (potential) errors. We should keep that up to date. With roughly one release per year for pyflakes that seems manageable.

scarlehoff commented 4 years ago

With roughly one release per year for pyflakes that seems manageable.

Mm, that looks acceptable I guess.

scarlehoff commented 4 years ago

Looking at these, I'm surprised flake's tests ever passed!

Indeed, thanks for the fix!