scarletcafe / jishaku

A debugging and testing cog for discord.py rewrite bots.
https://jishaku.readthedocs.io/en/latest/
MIT License
543 stars 182 forks source link

interaction_check issue #149

Closed ITKewai closed 2 years ago

ITKewai commented 2 years ago

Summary

Reproduction steps

Use for example jsk sh a command

Expected results

Interaction bottons to work

Actual results

Interaction buttons doesn't work cause of breakingchanges https://github.com/iDevision/enhanced-discord.py/commit/1fae5bface6cdd00cdd22b9247eb62a804cbe9d3

Ignoring exception in view <PaginatorInterface timeout=7200 children=6> for item <Button style=<ButtonStyle.secondary: 2> url=None disabled=False label='▶' emoji=None row=None>:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/discord/ui/view.py", line 353, in _scheduled_task
    allow = await self.interaction_check(item, interaction)
TypeError: interaction_check() takes 2 positional arguments but 3 were given

Checklist

System information

Name: jishaku Version: 2.3.2 Summary: A discord.py extension including useful tools for bot development and debugging. Home-page: https://github.com/Gorialis/jishaku Author: Devon (Gorialis) R Author-email: None License: MIT Location: /usr/local/lib/python3.8/dist-packages Requires: click, braceexpand, import-expression Required-by:

scarletcafe commented 2 years ago

This is a pretty awkward signature change. Thinking about what I should do about it