NotOwner not raised when user isnt owner

[Motzumoto]

Summary

When someone who isnt the bot owner runs jsk it doesnt return a not owner error. It doesnt look to return anything

Reproduction steps

My error handler goes as follows: https://haste.powercord.dev/avulevowin (sentry error handling hidden due to privacy reasons(its at the very bottom of the error handler and i dont think its necessary to display it)) Get any account that isnt the bot owner and this is what gets returned: https://i.lunardev.group/9ppGRdY/direct

Expected results

I expect for it to return NotOwner; "You must own this bot to use JSK" or something along those lines. From what i remember it USED to do this.

Actual results

Returns nothing

Checklist

• [x] I have updated discord.py and jishaku to the latest available versions and have confirmed that this issue is still present
• [x] I have searched the open issues for duplicates
• [x] I have shown the entire traceback, if possible
• [x] I have removed my token from display, if visible

System information

• Python v3.10.4-final
• discord.py v2.1.0-alpha
  • discord.py metadata: v2.1.0a4582+ge8f6b29a
• aiohttp v3.7.4
• system info: Linux 5.15.0-43-generic #46-Ubuntu SMP Tue Jul 12 10:30:17 UTC 2022 discord.py version: 2.1.0a4582+ge8f6b29a Jsk version: 2.5.1a458+ga2a3752.master

I dont think this is an issue with my error handler as its just been rewritten, if you know how to fix it please let me know

[scarletcafe]

Nothing about this behavior has changed d.py or jishaku wise so this has to be some form of bug in your code somewhere. I can still easily see NotOwner raising matching your versions, so it's ultimately your job to figure out why your handler isn't picking it up.

I'd consider maybe looking into whether some of your other cases have MRO overlap with other exceptions (e.g. NotOwner is a CommandError, so handling CommandError first will shortcut the handling). You also abridged your code and it's possible the code you redacted could also be culprit somehow. (word of advice - you shouldn't really have it such that your code itself is sensitive - put your secrets elsewhere).

Regardless, pretty confident this isn't my bug so I'm closing this.

[Motzumoto]

You also abridged your code and it's possible the code you redacted could also be culprit somehow. (word of advice - you shouldn't really have it such that your code itself is sensitive - put your secrets elsewhere).

I hid the code because i believed it was unnecessary, its just a large function that gets called at an else at the very bottom of the file, so it shouldnt be causing any issues since it only gets called if all the conditionals dont get called