Closed AbstractUmbra closed 1 year ago
Is there a known way to fix this without using __future__
? I'd like to avoid having to opt into the lazy behavior, but I'll take it if nothing else works.
Is there a known way to fix this without using
__future__
? I'd like to avoid having to opt into the lazy behavior, but I'll take it if nothing else works.
To the extent of my knowledge on the matter, not really. I don't believe you can wrap the annotation as a string directly, but I can try. (e.g. a: "MaybeButton[T]"
).
The other option is going from 3.11.0 -> 3.11.1 as it is (seemingly?) resolved in this version, but I cannot pinpoint the CPython commit/change that fixed it.
Hard sell bumping right up until the latest patch version. I might have been able to do that in the old Jishaku days, but probably the best I could reasonably do today is pushing up to 3.10. I'll let the checks run and merge if there are no issues.
Aaand it seems to break Sphinx. Cool stuff! This kind of stuff is sort of why I wanted to avoid it, I guess it might be fixable with a typing guard or something?
I'll just figure it out on my end.
Seems this fix doesn't actually cause the sphinx problems, some change on sphinx's side causing this.
The annotations of this file are eagerly evaluated rather than postponed causing an issue due to a CPython bug in 3.11.0
Rationale
Fixes an issue on 3.11+.
Summary of changes made
Forces the
paginator_200.py
file to use future annotations to prevent the following traceback:-Checklist