Closed 0x2x closed 1 year ago
This PR doesn't meet the necessary quality standards for a number of reasons. Usually I would just mark them in review and request changes, but there's enough here to the point where it would be faster to scrap this version and start again. Some things I picked out just from a skim:
type(x) = y
isn't the way you're supposed to do this kind of instance check (and you shouldn't even be using it here - you should know what type you're dealing with when interacting with an API, and this repo uses strict pylance)This is only the the surface-level problems, so "needs work" would be appropriate here (arguably less of it, most of these issues are because this is over-complicated as a solution, needs more effort put towards design than LOC).
These edits allow users to drop an attachment file and have the code run also allows users to use URLS and allow them to run.