scaron / prettyphoto

prettyPhoto is a jQuery based lightbox clone. Not only does it support images, it also add support for videos, flash, YouTube, iFrames. It’s a full blown media lightbox. The setup is easy and quick, plus the script is compatible in every major browser.
http://www.no-margin-for-errors.com/projects/prettyPhoto-jquery-lightbox-clone/
553 stars 281 forks source link

Related issue with option "horizontal_padding" #114

Open sunblognuke opened 11 years ago

sunblognuke commented 11 years ago

Hi there,

The option 'horizontal_padding' included in the default pp_settings but actually it is not used as expected or explained "The padding on each side of the picture". Found all the code and it only at one place - be utilized at the following code to build container width:

line 611: containerWidth:Math.floor(pp_containerWidth) + (settings.horizontal_padding * 2)

And it may make your popup window look strange with big empty space right. So I suggest that this option should be removed so not confused by others.

And there is another trick code for this option:

if(settings.theme == 'pp_default') settings.horizontal_padding = 16;

In my opinion, the value 17 will be better.

You check out those issues with some testings.

Hope it helps for others, too.

Regards Baldwin