search

scaron / prettyphoto

prettyPhoto is a jQuery based lightbox clone. Not only does it support images, it also add support for videos, flash, YouTube, iFrames. It’s a full blown media lightbox. The setup is easy and quick, plus the script is compatible in every major browser.
http://www.no-margin-for-errors.com/projects/prettyPhoto-jquery-lightbox-clone/
553 stars 281 forks source link

Wrong calculation in IE7/8 #90

Open helloRoger opened 12 years ago

helloRoger commented 12 years ago

Hi, i found that if using PP to display inline content in IE 7/8, the 'top' is calculated wrongly.

I am using PP 3.1.4. Please help!! Thanks!

atwright147 commented 10 years ago

I have also found this to be a problem.

atwright147 commented 10 years ago

There is a simple fix at: http://forums.no-margin-for-errors.com/discussion/2067/vertical-align-bug-ie8/p1

@scaron Are you accepting Pull Requests? If so, I will try to creat on for you.

scaron commented 10 years ago

Hi Andy,

I am accepting pull request so push away!

Thanks for the report.

On Monday, January 6, 2014, Andy Wright wrote:

There is a simple fix at: http://forums.no-margin-for-errors.com/discussion/2067/vertical-align-bug-ie8/p1

@scaron https://github.com/scaron Are you accepting Pull Requests? If so, I will try to creat on for you.

— Reply to this email directly or view it on GitHubhttps://github.com/scaron/prettyphoto/issues/90#issuecomment-31653568 .

atwright147 commented 10 years ago

Hi @scaron

This is the pull request I promised.

Cheers